Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Boid Flocking model to benchmark #104

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

coderbeta1
Copy link
Contributor

Changes Made:

  1. Benchmark: Changed the default values and code to that of benchmark

@coderbeta1 coderbeta1 marked this pull request as ready for review February 25, 2024 14:43
@rht rht merged commit 3a593b3 into projectmesa:main Feb 25, 2024
3 checks passed
@rht
Copy link
Contributor

rht commented Feb 25, 2024

Merged, thank you.

@EwoutH
Copy link
Member

EwoutH commented Feb 28, 2024

Thanks for this. However, please do note that there’s a difference between the purpose of the examples and the benchmarks:

  • The examples are public facing and should show best practices in Mesa modeling. This includes code cleanness and reliability.
  • The benchmarks are an internal development tool, and are focused on optimizing performance, sometimes as the costs of readability or complexity.

Since both have their own, different purposes they may differ (significantly) in some cases.

In this case I find the new implementation less structured and readable.

@rht
Copy link
Contributor

rht commented Feb 28, 2024

The one consistent with benchmark has division by N instead of by 2. This is also consistent with the implementation in https://github.com/JuliaDynamics/ABM_Framework_Comparisons, which has the fix JuliaDynamics/ABMFrameworksComparison#73.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants