-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update ga workflows to be consistent with mesa #185
Conversation
wang-boyu
commented
Jan 17, 2024
- drop support for python 3.8
- remove redundant linters which are included in pre-commit.ci
- run release workflow when tags are created
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
=======================================
Coverage 78.14% 78.14%
=======================================
Files 10 10
Lines 691 691
Branches 151 151
=======================================
Hits 540 540
Misses 127 127
Partials 24 24 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@@ -1,6 +1,8 @@ | |||
name: Release | |||
on: | |||
push: | |||
tags: | |||
- "v*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be the case as well in projectmesa/mesa?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't really matter, I think