Fix: Property layer visualization for HexGrid #2646
Conversation
for more information, see https://pre-commit.ci
…Sahil-Chhoker/mesa into property-layer-fix-for-hex-grid
|
Performance benchmarks:
|
|
Thanks for this. The example looks great. I am taking a look at the code now. |
|
Are you sure it's fine as it is? I had a few questions about it:
|
|
I gave it a first quick pass and focussed on the high-level stuff. The zorder one is a good question (and actually interacts with #2642). Ideally (but beyond this pr), zorder should become controllable for property layers to explicitly control layering. |
|
Thank you for the review! I have added the suggested changes. Please let me know if you have any additional recommendations to further improve the code quality. |
|
|
||
| @lru_cache(maxsize=1024, typed=True) | ||
| def _get_hexmesh( | ||
| width: int, height: int, size: float |
There was a problem hiding this comment.
Can you make size a keyword argument with a default value of 1?
| @@ -159,6 +160,37 @@ def draw_space( | |||
| return ax | |||
|
|
|||
|
|
|||
| # Helper function for getting the vertices of a hexagon given the center and size | |||
| def _get_hex_vertices( | |||
There was a problem hiding this comment.
perhaps move this to an inner function in _get_hexmesh?
| # Edge logic, connecting each vertex to the next | ||
| for v1, v2 in pairwise([*vertices, vertices[0]]): | ||
| # Sort vertices to ensure consistent edge representation and avoid duplicates. | ||
| # Sort vertices to ensure consistent edge representation |
Summary
Property layers were not properly visualized for HexGrids, and this PR aims to resolve that issue. It utilizes the same coordinate system as the
draw_hex_gridfunction and generates aPolyCollectionthat overlays color values on the grid.Bug / Issue
fixes #2433
Before
After
Additional Notes:
I am not entirely sure if this was the best approach to address the issue. If there is a more effective or elegant solution, I would greatly appreciate your recommendations.