Restructure K8up image specification #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We restructure the K8up container image specification to populate `backup_k8up:images:k8up` from the lookup table containing the default image versions for K8up v1.x and v2.x instead of populating v2 of the lookup table from `backup_k8up:images:k8up`. While breaking the Commodore component best practices, this brings the container image specification in line with the Helm chart specification and restructures the class enough to avoid running into a bug when resolving nested references in reclass which we hit with the old structure
simu
force-pushed
the
fix/k8up-v1-v2-reclass
branch
from
169ada1
to
168fbe7
Compare
glrf
approved these changes
Jul 25, 2022
ccremer
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We restructure the K8up container image specification to populate
backup_k8up:images:k8upfrom the lookup table containing the default image versions for K8up v1.x and v2.x instead of populating v2 of the lookup table frombackup_k8up:images:k8up.While breaking the Commodore component best practices, this brings the container image specification in line with the Helm chart specification and restructures the class enough to avoid running into a bug when resolving nested references in reclass which we hit with the old structure
See kapicorp/reclass#8 for a potential fix of the underlying reclass bug.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.