Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bootstrapping issue in PreSync hook #140

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Fix bootstrapping issue in PreSync hook #140

merged 3 commits into from
Sep 16, 2024

Conversation

HappyTetrahedron
Copy link
Contributor

By turning the required SA into a PreSync hook, it gets created before the job which uses it.

Tested on the new cluster by deleting the service account and then syncing.

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@HappyTetrahedron HappyTetrahedron added the bug Something isn't working label Sep 13, 2024
@HappyTetrahedron HappyTetrahedron requested a review from a team September 13, 2024 10:05
simu
simu reviewed Sep 13, 2024
View reviewed changes
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Role and RoleBinding also need the PreSync annotation, otherwise the presync hook will still fail.

@HappyTetrahedron
Copy link
Contributor Author

My brain was already in friday mode 🙈

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 16, 2024 •
edited
Loading

🚀 This PR has been released as v1.9.8

Triggering workflows Release

🛠️ Auto tagging enabled with label bump:patch

@HappyTetrahedron HappyTetrahedron merged commit bd2a6a4 into master Sep 16, 2024
20 checks passed
@HappyTetrahedron HappyTetrahedron deleted the fix/presync branch September 16, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simu simu simu approved these changes

Assignees
No one assigned
Labels
bug Something isn't working bump:patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HappyTetrahedron @simu