Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor reconciler #120

Merged
merged 23 commits into from
Oct 27, 2020
Merged

Refactor reconciler #120

merged 23 commits into from
Oct 27, 2020

Commits on Oct 22, 2020

  1. Refactored everything

    Simon Beck committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    40a1621 View commit details
    Browse the repository at this point in the history

  2. Fix race conditions 

    Add tenant as owner to clusters
    Simon Beck committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    d9645b8 View commit details
    Browse the repository at this point in the history

  3. Make git repos watch tenants and clusters 

    With this change the pull methods now work instantly. If a `cluster` is
created, it will trigger a `tenant` reconcile via owner reference. The
tenant reconcile in turn triggers a gitrepo reconcile via the
`EnqueueRequestsFromMapFunc` and watches on both `clusters` and
`tenants`.
    Simon Beck committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    38bed2a View commit details
    Browse the repository at this point in the history

  4. Cherry pick changes since refactor

    Simon Beck committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    8c22648 View commit details
    Browse the repository at this point in the history

  5. Update gitignore

    Simon Beck committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    dd58cbb View commit details
    Browse the repository at this point in the history

  6. Fix tenant repo cleanup

    Simon Beck committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    ac9f0de View commit details
    Browse the repository at this point in the history

  7. Also move unit tests

    Simon Beck committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    69c22f4 View commit details
    Browse the repository at this point in the history

  8. Add lots of unit tests

    Simon Beck committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    508cf82 View commit details
    Browse the repository at this point in the history

  9. Last batch of unit tests

    Simon Beck committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    371bc69 View commit details
    Browse the repository at this point in the history

  10. Fix failing unit tests 

    Some changes to the order of thins make the unit tests fail. Also there
were tests that checked the older push method for gitRepo changes. Those
were removed.
    Simon Beck committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    39de878 View commit details
    Browse the repository at this point in the history

  11. Update changelog

    Simon Beck committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    53bc48e View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2020

  1. Remove kubectl dependency

    Simon Beck committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    9764494 View commit details
    Browse the repository at this point in the history

  2. Use loops to execute steps

    Simon Beck committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    3dca636 View commit details
    Browse the repository at this point in the history

  3. Get rid of generic utils package

    Simon Beck committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    d6afaee View commit details
    Browse the repository at this point in the history

  4. Move test cases outside of tests funcs

    Simon Beck committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    efdeb37 View commit details
    Browse the repository at this point in the history

  5. Fix assert scopes

    Simon Beck committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    5d54680 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2020

  1. Implement PR suggestions

    Simon Beck committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    6405e5e View commit details
    Browse the repository at this point in the history

  2. Trim excessive whitespaces

    Simon Beck committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    4e0bd2d View commit details
    Browse the repository at this point in the history

  3. Remove ineffective assignement

    Simon Beck committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    17c9781 View commit details
    Browse the repository at this point in the history

  4. Remove unused code

    Simon Beck committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    a6d311c View commit details
    Browse the repository at this point in the history

  5. Remove unused code

    Simon Beck committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    19fcb0f View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2020

  1. Align git repo unit tests with the rest

    Simon Beck committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    5ccb0cf View commit details
    Browse the repository at this point in the history

  2. Remove resultNotOK and wrapError 

    They are no longer necessary.
    Simon Beck committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    8586189 View commit details
    Browse the repository at this point in the history