Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.8 which is EOL #143

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Drop support for Python 3.8 which is EOL #143

merged 1 commit into from
Nov 19, 2024

Conversation

simu
Copy link
Member

@simu simu commented Nov 19, 2024

Python 3.8 has become EOL in October 2024. This commit bumps the supported Python versions for reclass-rs to >=3.9. This is done in preparation for PyO3 0.23 (#142) which drops support for building wheels for PyPy < 3.9.

Factored out from #142

Checklist

  • The PR has a meaningful title. The title will be used to auto generate the changelog
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency, internal
    as they show up in the changelog
  • Link this PR to related PRs or issues.

Python 3.8 has become EOL in October 2024. This commit bumps the
supported Python versions for reclass-rs to `>=3.9`.
@simu simu added the breaking label Nov 19, 2024
Copy link

Benchmark for a9bb6e5

Click to view benchmark
Test Base PR %
Reclass::inventory() multi-threaded 1626.3±60.13µs 1637.8±53.26µs +0.71%
Reclass::inventory() single-threaded 3.7±0.04ms 3.7±0.09ms 0.00%

Copy link

@schemen schemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simu simu merged commit f342afa into main Nov 19, 2024
18 checks passed
@simu simu deleted the drop-python-3.8 branch November 19, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants