Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom list types which are suitable for Reclass's classes and applications arrays #5

Merged
merged 4 commits into from
Aug 30, 2023

Conversation

simu
Copy link
Member

@simu simu commented Aug 30, 2023

The UniqueList type corresponds to the Python Reclass Classes type (cf. https://github.com/kapicorp/reclass/blob/develop/reclass/datatypes/classes.py) and the RemovableList type corresponds to the Python Reclass Applications type (cf. https://github.com/kapicorp/reclass/blob/develop/reclass/datatypes/applications.py).

Notably, the RemovableList type incorporates the changes proposed to Python Reclass in kapicorp/reclass#9 which will address the longstanding issue where in some situations it's not possible to remove entries from the applications array.

Checklist

  • The PR has a meaningful title. The title will be used to auto generate the changelog
  • PR contains a single logical change (to build a better changelog).
  • Update tests.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency, internal
    as they show up in the changelog

@simu simu added the enhancement New feature or request label Aug 30, 2023
@simu simu force-pushed the feat/custom-list-types branch 3 times, most recently from c701600 to 23c49f5 Compare August 30, 2023 12:53
@simu simu marked this pull request as ready for review August 30, 2023 13:05
@simu simu requested a review from a team August 30, 2023 13:05
src/list/removable.rs Outdated Show resolved Hide resolved
src/list/removable.rs Show resolved Hide resolved
Copy link

@bastjan bastjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Serde is cool 😊

@simu simu merged commit cca5463 into main Aug 30, 2023
16 checks passed
@simu simu deleted the feat/custom-list-types branch August 30, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants