Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align ig #118

Merged
merged 12 commits into from
Jan 14, 2025
Merged

Align ig #118

merged 12 commits into from
Jan 14, 2025

Conversation

lmd59
Copy link
Contributor

@lmd59 lmd59 commented Jan 13, 2025

Summary

Makes various updates to align the front end application with the implemented functionality in the backend to align more fully with the capabilities expected in the IG. Also makes one update in the backend to support expected functionality.

New behavior

New capabilities in the front end include: $approve capability, $clone for active and retired measures, CRUD for non-draft measures (publish, retire, archive), and search for draft artifacts.
Backend has been updated to limit $draft to active artifacts.

Code changes

  • Updates to dependencies to update tabler icons and use codemirror for the added code editor.
  • All Icons across the app now named "Icon*", i.e. Message to IconMessage
  • Added CodeEditorModal (same as in fqm-testify)
  • Update ConfirmationModal to handle additional actions
  • ResourceInfoCard: Update all language to not read "draft" in non-draft cases, invalidate page for active/retired artifact updates, add retire and archive capabilities, expand button icon logic for active/retired artifacts
  • Expand SearchComponent to be used in either draft or active/retired contexts
  • Expand all pulls of active measures to also pull retired artifacts
  • Order both active/retired and draft artifacts by url|version
  • For search-result, use the draft/authoring context to pass through the correct results
  • Update _app to highlight the correct tab and show the search based on the draft/authoring context
  • Add search bar to /authoring/[resourceType]/index.tsx page
  • Add publish functionality to active index page (under the capability statement info)
  • Add approve capabilities to the review page and update input validation to match spec
  • Add approveDraft trpc procedure to draft router (and adjust parameters passed through for $review)
  • Add publish, retire, and archive to service router procedures

Server side:

  • Add check in Measure and Library services for active artifact for the draft operation

Testing guidance

Copy link
Contributor

@elsaperelli elsaperelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!!! Just a couple of small comments in addition to the things we discussed in our huddle today!

app/src/server/trpc/routers/service.ts Outdated Show resolved Hide resolved
app/src/components/CodeEditorModal.tsx Show resolved Hide resolved
app/src/components/ResourceInfoCard.tsx Outdated Show resolved Hide resolved
app/src/components/ResourceInfoCard.tsx Show resolved Hide resolved
app/src/components/ResourceInfoCard.tsx Outdated Show resolved Hide resolved
app/src/pages/index.tsx Show resolved Hide resolved
app/src/pages/review/[resourceType]/[id].tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@elsaperelli elsaperelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@lmd59 lmd59 marked this pull request as ready for review January 14, 2025 15:39
@elsaperelli elsaperelli self-assigned this Jan 14, 2025
@lmd59 lmd59 merged commit ea79b32 into main Jan 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants