generated from projecttacoma/node-fhir-server-ts-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align ig #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsaperelli
requested changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome!!! Just a couple of small comments in addition to the things we discussed in our huddle today!
elsaperelli
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
Remove "draft" language, fix reload, retire/archive notifications, disable draft button for retired resources, ordered resources by url|version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Makes various updates to align the front end application with the implemented functionality in the backend to align more fully with the capabilities expected in the IG. Also makes one update in the backend to support expected functionality.
New behavior
New capabilities in the front end include: $approve capability, $clone for active and retired measures, CRUD for non-draft measures (publish, retire, archive), and search for draft artifacts.
Backend has been updated to limit $draft to active artifacts.
Code changes
Message
toIconMessage
search-result
, use the draft/authoring context to pass through the correct results_app
to highlight the correct tab and show the search based on the draft/authoring contextapproveDraft
trpc procedure to draft router (and adjust parameters passed through for $review)Server side:
Testing guidance
npm install
npm run check:all
npm run start:all