Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(treesitter): elixir module/atom colors #366

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

paytonward6
Copy link
Contributor

@paytonward6 paytonward6 commented Oct 1, 2024

Fixes highlighting of Modules/atoms in Elixir

Before

before

After

after

@tmillr tmillr changed the title fix(Color): use proper Elixir module/atom colors fix(treesitter): elixir module/atom colors Dec 31, 2024
@tmillr
Copy link
Member

tmillr commented Dec 31, 2024

Thank you!


  • Fix highlight of modules (module names) in elixir.
  • Link @string.special.symbol -> @constant, which fixes/improves the highlight of symbols/atoms in elixir.

Note

Technically, github.com uses the string color (i.e. @string) for elixir atoms currently, but other langs (e.g. Ruby) use the constant (i.e. @constant) color. We'll let elixir use the default of @constant for now for consistency and simplicity.

paytonward6 and others added 2 commits December 30, 2024 21:38
- Fix highlight of modules (module names) in elixir.

- Link `@string.special.symbol` -> `@constant`, which fixes/improves the
  highlight of symbols/atoms in elixir.

NOTE: Technically, github.com uses the string color (i.e. `@string`) for
      elixir atoms currently, but other langs (e.g. Ruby) use the
      constant (i.e. `@constant`) color. We'll let elixir use the
      default of `@constant` for now for consistency and simplicity.
@tmillr tmillr force-pushed the fix-elixir-atom-module-colors branch from 496fb37 to a9e186b Compare December 31, 2024 10:07
@tmillr tmillr merged commit c106c94 into projekt0n:main Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants