fix/stats race #145
Merged
fix/stats race #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perhallgren
force-pushed
the
fix/stats-race
branch
from
37727ce to
ea854d8
Compare
|
This needs a DCO sign-off. You can use |
perhallgren
force-pushed
the
fix/stats-race
branch
from
ea854d8 to
4085f6a
Compare
|
Hmm, should we also protect Maybe we should just migrate these values to Go |
perhallgren
force-pushed
the
fix/stats-race
branch
2 times, most recently
from
b6ccd59 to
b23432d
Compare
Good catch, added! |
The test currently fails as `PacketsSent` is not protected by `statsMu` in `sendICMP`. Signed-off-by: Per Hallgren <[email protected]>
Writes to the following fields are now protected by `statsMu`: - `ipaddr` - `addr` - `PacketsSent` - `PacketsRecvDuplicates` Signed-off-by: Per Hallgren <[email protected]>
perhallgren
force-pushed
the
fix/stats-race
branch
from
b23432d to
cb7d28f
Compare
|
@SuperQ marked as ready for review. Would you like to use atomics instead of the lock? I think both will start to feel a bit ad-hoc, since there's no intuitive boundary what variables are protected by the lock and which ones are just atomic. |
|
Potentially one could rewrite to use atomics for all variables that we read as a result of a call to |
SuperQ
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PacketsSentwas not protected bystatsMuwhen being incremented insendICMP, which gave a data race when callingStatistics()on a runningPinger.This PR adds a small test to test for the data race, and fixes the issue.