hyperv: Refactor collector, added DataStore, Virtual SMB and Dynamic …

…Memory Balancer metrics (click PR number for more information) (#1712) Signed-off-by: Jan-Otto Kröpke <[email protected]>
prometheus-community · Nov 19, 2024 · fdee2d8 · fdee2d8
1 parent 8c90961
commit fdee2d8
Show file tree

Hide file tree

Showing 29 changed files with 4,335 additions and 1,947 deletions.
diff --git a/.github/workflows/spelling.yml b/.github/workflows/spelling.yml
@@ -23,4 +23,4 @@ jobs:
           check_filenames: true
           # When using this Action in other repos, the --skip option below can be removed
           skip: ./.git,go.mod,go.sum
-          ignore_words_list: calle
+          ignore_words_list: calle,Entires
diff --git a/docs/collector.hyperv.md b/docs/collector.hyperv.md
diff --git a/internal/collector/cpu/cpu.go b/internal/collector/cpu/cpu.go
@@ -113,31 +113,6 @@ func (c *Collector) Build(_ *slog.Logger, _ *mi.Session) error {
 		nil,
 		nil,
 	)
-
-	c.cStateSecondsTotal = prometheus.NewDesc(
-		prometheus.BuildFQName(types.Namespace, Name, "cstate_seconds_total"),
-		"Time spent in low-power idle state",
-		[]string{"core", "state"},
-		nil,
-	)
-	c.timeTotal = prometheus.NewDesc(
-		prometheus.BuildFQName(types.Namespace, Name, "time_total"),
-		"Time that processor spent in different modes (dpc, idle, interrupt, privileged, user)",
-		[]string{"core", "mode"},
-		nil,
-	)
-	c.interruptsTotal = prometheus.NewDesc(
-		prometheus.BuildFQName(types.Namespace, Name, "interrupts_total"),
-		"Total number of received and serviced hardware interrupts",
-		[]string{"core"},
-		nil,
-	)
-	c.dpcsTotal = prometheus.NewDesc(
-		prometheus.BuildFQName(types.Namespace, Name, "dpcs_total"),
-		"Total number of received and serviced deferred procedure calls (DPCs)",
-		[]string{"core"},
-		nil,
-	)
 	c.cStateSecondsTotal = prometheus.NewDesc(
 		prometheus.BuildFQName(types.Namespace, Name, "cstate_seconds_total"),
 		"Time spent in low-power idle state",

diff --git a/internal/collector/cs/cs.go b/internal/collector/cs/cs.go
@@ -23,10 +23,10 @@ type Collector struct {
 	config Config
 
 	// physicalMemoryBytes
-	// Deprecated: Use windows_cpu_logical_processor instead
+	// Deprecated: Use windows_physical_memory_total_bytes instead
 	physicalMemoryBytes *prometheus.Desc
 	// logicalProcessors
-	// Deprecated: Use windows_physical_memory_total_bytes instead
+	// Deprecated: Use windows_cpu_logical_processor instead
 	logicalProcessors *prometheus.Desc
 	// hostname
 	// Deprecated: Use windows_os_hostname instead