Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually use symfony matrix in tests #97

Merged
merged 5 commits into from
May 28, 2024

Conversation

mkilmanas
Copy link
Contributor

By adding symfony/flex globally and passing SYMFONY_REQUIRE env param it ensures that all symfony packages are coming from the same symfony-version provided by the test matrix.

P.S. This also includes #96 as otherwise unable to build 7.0.* branch due to incompatibilities.

@unixslayer
Copy link
Member

@mkilmanas please rebase onto current master branch

@mkilmanas mkilmanas force-pushed the use-symfony-matrix-in-tests branch from e5ce0a9 to 794c37d Compare May 27, 2024 20:13
@coveralls
Copy link

coveralls commented May 27, 2024

Pull Request Test Coverage Report for Build 9260014815

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 94.118%

Totals Coverage Status
Change from base Build 9259328194: 0.2%
Covered Lines: 528
Relevant Lines: 561

💛 - Coveralls

@mkilmanas
Copy link
Contributor Author

Had to exclude Symfony 7 vs PHP 8.1 combo from the matrix, because Symfony 7 itself requires php >= 8.2, so it was not installable by composer.

@unixslayer
Copy link
Member

@mkilmanas awesome. Thanks.

@unixslayer unixslayer merged commit a502004 into prooph:master May 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants