Check if matches are empty strings, not if they exist

Pass php stan?
propelorm · Sep 17, 2024 · 3d244ef · 3d244ef
1 parent 2a556f5
commit 3d244ef
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/Propel/Generator/Reverse/MysqlSchemaParser.php b/src/Propel/Generator/Reverse/MysqlSchemaParser.php
@@ -237,7 +237,7 @@ public function getColumnFromRow(array $row, Table $table): Column
         $/x';
         if (preg_match($regexp, $row['Type'], $matches)) {
             $nativeType = $matches[1];
-            if ($matches[2]) {
+            if (strlen($matches[2])>0) {
                 $cpos = strpos($matches[2], ',');
                 if ($cpos !== false) {
                     $size = (int)substr($matches[2], 0, $cpos);
@@ -246,7 +246,7 @@ public function getColumnFromRow(array $row, Table $table): Column
                     $size = (int)$matches[2];
                 }
             }
-            if ($matches[3]) {
+            if (strlen($matches[3])>0) {
                 $sqlType = $row['Type'];
             }
             if (isset(static::$defaultTypeSizes[$nativeType]) && $scale == null && $size === static::$defaultTypeSizes[$nativeType]) {