Code quality: Fix single table inheritance classkey type #1982
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using single table inheritance, the keys for the individual classes are written to the TableMap as constants. Those are used during instantiation of the subclasses.
For example, an inheritance declaration like
will create a constant in the TableMap:
and a constructor of the subclass:
The value of the classkey constant is always written as a string, even for numeric values:
This leads to a type error in the generated constructor code, since the setter function for the numeric field will expect a numeric value.
With the changes in this PR, numeric class key constants are written as numeric values, fixing the type error.
Includes the test fix from #1980.