Prevent crash when encountering the 'any' type argument #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes proper-testing#94 where proper_typeserver would crash when resolving the 'erlang:timestamp()' type in OTP 17.x. The underlying problem is that we were encountering the 'map()' type in the erlang module with an argument of 'any'. At this point, the typeserver only knew how to handle this situation for tuples. Support has been extended to properly handle this argument for other types, and the 'map()' type will now correctly be identified as unsupported rather than causing a crash. For example: 1> proper_typeserver:demo_translate_type(erlang, "map()"). {error,{unsupported_type,{type,1,map,any}}}
danielwhite
force-pushed
the
any-type-argument
branch
from
afe8a77 to
97c5841
Compare
|
@kostis, any comment on this? I realise there is a conflict due to the introduction of |
|
Assuming this is resolved due to #118. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #94 in which proper_typeserver would crash when resolving the
'erlang:timestamp()' type in OTP 17.x.
The underlying problem is that we were encountering the 'map()' type in
the erlang module with an argument of 'any'. At this point, the
typeserver only knew how to handle this situation for tuples.
Support has been extended to properly handle this argument for other
types, and the 'map()' type will now correctly be identified as
unsupported rather than causing a crash.
For example:
1> proper_typeserver:demo_translate_type(erlang, "map()").
{error,{unsupported_type,{type,1,map,any}}}