Add Merge to prototext.UnmarshalOptions #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a Merge option to prototext.UnmarshalOptions to match proto.UnmarshalOptions. This is particularly useful when needing to read multiple textproto files of the same format that wrap a single repeated field. I've added this to the exact same position in the UnmarshalOptions struct as the proto version. It can be moved to the bottom of the struct definition if that would cause backwards compatibility issues, but I wasn't aware of any.
|
Thank you for your interest into contributing to this project. Unfortunately this project does not accept GitHub pull requests as the source-of-truth for this project is hosted at https://go.googlesource.com/protobuf. This project page on GitHub is a mirror of that other repository. If you would like to contribute to this project, please follow the contribution guidelines for instructions on how to send a change. If the change you'd like to make is more substantial or introduces any new features, then it should first be discussed on the issue tracker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Merge option to prototext.UnmarshalOptions to match proto.UnmarshalOptions. This is particularly useful when needing to read multiple textproto files of the same format that wrap a single repeated field.
I've added this to the exact same position in the UnmarshalOptions struct as the proto version. It can be moved to the bottom of the struct definition if that would cause backwards compatibility issues, but I wasn't aware of any.