Skip to content

Commit

Permalink
Fixes -lpthread problem when building with android_arm64 config (#20337)
Browse files Browse the repository at this point in the history
When using `--platforms=//:android_arm64` on command line, the build fails to match any android condition.

```
platform(
    name = "android_arm64",
    constraint_values = [
        "@platforms//os:android",
        "@platforms//cpu:arm64",
    ],
)
```

Closes #20337

COPYBARA_INTEGRATE_REVIEW=#20337 from stakira:patch-1 623053c
PiperOrigin-RevId: 726741995
  • Loading branch information
stakira authored and copybara-github committed Feb 14, 2025
1 parent bdf334c commit 4f5968a
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions build_defs/cpp_opts.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ COPTS = select({

# Android and MSVC builds do not need to link in a separate pthread library.
LINK_OPTS = select({
"@platforms//os:android": [],
"//build_defs:config_android": [],
"//build_defs:config_android-legacy-default-crosstool": [],
"//build_defs:config_android-stlport": [],
Expand Down

0 comments on commit 4f5968a

Please sign in to comment.