Create the exchange module #1661

SpicyLemon · 2023-08-23T19:22:45Z

Description

closes: #1698

related: #1658

This PR creates the exchange module and adds it to the app.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer
Review Codecov Report in the comment section below once CI passes

codecov · 2023-08-29T01:08:34Z

Codecov Report

Merging #1661 (f48c014) into main (df2d286) will decrease coverage by 1.65%.
The diff coverage is 47.76%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1661      +/-   ##
==========================================
- Coverage   64.68%   63.03%   -1.65%     
==========================================
  Files         269      288      +19     
  Lines       31822    36461    +4639     
==========================================
+ Hits        20583    22982    +2399     
- Misses       9922    12139    +2217     
- Partials     1317     1340      +23

Files	Coverage Δ
app/app.go	`84.89% <100.00%> (+0.21%)`	⬆️
app/upgrades.go	`68.98% <100.00%> (+1.98%)`	⬆️
x/exchange/events.go	`100.00% <100.00%> (ø)`
x/exchange/genesis.go	`100.00% <100.00%> (ø)`
x/exchange/helpers.go	`100.00% <100.00%> (ø)`
x/exchange/keys.go	`100.00% <100.00%> (ø)`
x/exchange/market.go	`100.00% <100.00%> (ø)`
x/exchange/orders.go	`95.52% <ø> (ø)`
x/exchange/params.go	`100.00% <ø> (ø)`
x/name/keeper/keeper.go	`77.41% <ø> (-1.92%)`	⬇️
... and 13 more

…art from the full key makers a bit more.

…ee denoms in the key. Create a suffix maker and parser for those keys too.

…tlementFee to return more info about why a fee is insufficient.

…d ratio fee entry updaters.

…e bool, permissions, and required attributes.

…arket id field to genesis.

…ul. Make sure MsgGovManageFeesRequest has a market id.

…ke in a store.

…Ratio ParseFeeRatioStoreValue tests.

… value.

… indexing.

… CanCreateBid.

x/exchange/orders_test.go

x/exchange/fulfillment_test.go

x/exchange/market_test.go

Taztingo · 2023-10-17T16:04:01Z

We will need to update internal/stargate_whitelist.go to contain the exchange queries we want provwasm to support.

x/exchange/keeper/grpc_query.go

SpicyLemon · 2023-10-17T19:02:19Z

We will need to update internal/stargate_whitelist.go to contain the exchange queries we want provwasm to support.

Oops! Good call. I need to add the hold module queries too.

Update: They've been added.

…il (which the store doesn't allow).

…or if there are no ratios found but the market does have ratios.

…rSettlementFlatFee to use the correct key maker.

… isn't provided, have the error include the required options.

… that isn't satisfied.

SpicyLemon added 29 commits September 1, 2023 12:19

[1658]: get/set store stuff for the settlement flat fees.

421df54

[1658]: Rename the key prefix makers to start with Get to set them ap…

876ffa3

…art from the full key makers a bit more.

[1658]: Create a generic iterator and use that for the GetParams func.

9b3bf96

[1658]; Switch to a record separator byte to separate the price and f…

443e296

…ee denoms in the key. Create a suffix maker and parser for those keys too.

[1658]: Most of the settlement ratio stuff.

0ab7493

[1658]: Refactor IsAcceptableBuyerSettlementFee into ValidateBuyerSet…

c66113c

…tlementFee to return more info about why a fee is insufficient.

[1658]: Create keeper.getStore and use that everywhere. Write flat an…

cbe4130

…d ratio fee entry updaters.

[1658]: The rest of the market store stuff: inactive bool, user-settl…

8ea7281

…e bool, permissions, and required attributes.

[1658]: Add a last market id store entry and write CreateMarket(...).

b74bdd1

[1658]: Normalize the required attributes when storing them.

e2d848d

[1658]: Fill out GovCreateMarket.

9f2a4a5

[1658]: Add the endpoint comments to the msg server funcs.

b9c364c

[1658]: Add a market id field to the update fees message and a last m…

1d274e0

…arket id field to genesis.

[1658]: Get rid of NewGenesisState since it doesn't do anything helpf…

09c0309

…ul. Make sure MsgGovManageFeesRequest has a market id.

[1658]: Implement GovManageFees.

f259eb6

[1658]: Create a GetMarket function.

62fab32

[1658]: Create a known market id set of entries in the store.

e1a22b7

[1658]: Break out a lot of the keeper funcs into versions that can ta…

f0c2457

…ke in a store.

[1658]: Add some empty suffix/value tests to ParseKeySuffixSettlement…

5842062

…Ratio ParseFeeRatioStoreValue tests.

[1659]: Refactor ParseFeeRatioStoreValue due to nakedret linter error.

43adb83

[1658]: Take care of the keys unit test TODOs I recently added.

18684c5

[1658]: Create IsBidOrder and IsAskOrder functions.

c4960e7

[1658]: Refactor order state store plans; move the type byte into the…

a994bd0

… value.

[1658]: get/set/delete orders. Tweak some keys stuff related to order…

6c0b0f8

… indexing.

[1658]: Create index key parsers.

b807913

[1658]: Create the index iterators.

7e913a4

[1658]: Add the name keeper to the keeper and create CanCreateAsk and…

20a1903

… CanCreateBid.

[1658]: Add some extra explanation to the req attrs fields.

834f122

[1658]: Populate the create ask, create bid and cancel order messages.

aec6e34