Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBC Rate Limit #1692

Merged
merged 101 commits into from
Nov 30, 2023
Merged

IBC Rate Limit #1692

merged 101 commits into from
Nov 30, 2023

Conversation

Taztingo
Copy link
Contributor

Description

Adds Osmosis' ibc-rate-limit module to Provenance.

closes: #1498


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@Taztingo Taztingo added the ibc inter-blockchain communication label Sep 28, 2023
@Taztingo Taztingo added this to the v1.18.0 milestone Sep 28, 2023
@Taztingo Taztingo self-assigned this Sep 28, 2023
@Taztingo Taztingo changed the title Taztingo/1498 ibc rate limit IBC Rate Limit Sep 29, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #1692 (78217fc) into main (5553cbd) will decrease coverage by 0.06%.
Report is 2 commits behind head on main.
The diff coverage is 70.82%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1692      +/-   ##
==========================================
- Coverage   74.01%   73.96%   -0.06%     
==========================================
  Files         295      314      +19     
  Lines       44072    44875     +803     
==========================================
+ Hits        32622    33190     +568     
- Misses      10087    10296     +209     
- Partials     1363     1389      +26     
Files Coverage Δ
app/app.go 85.12% <100.00%> (+0.22%) ⬆️
app/upgrades.go 64.16% <ø> (ø)
cmd/provenanced/cmd/root.go 72.06% <100.00%> (+0.17%) ⬆️
internal/ibc/ibc.go 100.00% <100.00%> (ø)
x/ibcratelimit/events.go 100.00% <100.00%> (ø)
x/ibcratelimit/genesis.go 100.00% <100.00%> (ø)
x/ibcratelimit/keeper/msg_server.go 100.00% <100.00%> (ø)
x/ibcratelimit/msgs.go 100.00% <100.00%> (ø)
x/ibcratelimit/params.go 100.00% <100.00%> (ø)
x/ibcratelimit/simulation/decoder.go 100.00% <100.00%> (ø)
... and 14 more

@Taztingo Taztingo marked this pull request as ready for review November 20, 2023 15:54
@Taztingo Taztingo requested a review from a team as a code owner November 20, 2023 15:54
app/upgrades.go Outdated Show resolved Hide resolved
SpicyLemon
SpicyLemon previously approved these changes Nov 28, 2023
Copy link
Member

@iramiller iramiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@Taztingo Taztingo merged commit 30d19d9 into main Nov 30, 2023
40 of 41 checks passed
@Taztingo Taztingo deleted the taztingo/1498-ibc-rate-limit branch November 30, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ibc inter-blockchain communication
Projects
Development

Successfully merging this pull request may close these issues.

Add IBC rate limiting protection system
3 participants