-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBC Rate Limit #1692
Merged
Merged
IBC Rate Limit #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imports and types.
…l dependencies exist.
…unexpectedly changing.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1692 +/- ##
==========================================
- Coverage 74.01% 73.96% -0.06%
==========================================
Files 295 314 +19
Lines 44072 44875 +803
==========================================
+ Hits 32622 33190 +568
- Misses 10087 10296 +209
- Partials 1363 1389 +26
|
…ered that the mint module was minting more tokens and causing the supply to change. Osmosis did not have this problem because of their custom mint module.
SpicyLemon
reviewed
Nov 28, 2023
SpicyLemon
reviewed
Nov 28, 2023
SpicyLemon
reviewed
Nov 28, 2023
SpicyLemon
reviewed
Nov 28, 2023
SpicyLemon
reviewed
Nov 28, 2023
SpicyLemon
previously approved these changes
Nov 28, 2023
iramiller
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
SpicyLemon
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds Osmosis' ibc-rate-limit module to Provenance.
closes: #1498
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes