Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark v1.17.0-rc2 in the changelog and release notes. #1731

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

SpicyLemon
Copy link
Contributor

Description

Mark v1.17.0-rc2 in the changelog and release notes.

I accidentally made this change directly to release/v1.17.x and pushed it up. Since we can't push --force, I then reverted it and pushed that up to get the branch back to where it was before. Then I created this branch with the change so it could be PRd and merged like it should be.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@SpicyLemon SpicyLemon requested a review from a team as a code owner November 3, 2023 16:30
@SpicyLemon SpicyLemon merged commit b3ea4a9 into release/v1.17.x Nov 3, 2023
@SpicyLemon SpicyLemon deleted the dwedul/mark-1.17.0-rc2 branch November 3, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants