Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sgw): add storagegateway_fault_tolerance check #5570

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sansns
Copy link
Contributor

@sansns sansns commented Oct 29, 2024

Context

Checks to see if SGW gateways are running on EC2

Description

If the gateways are running on EC2, this introduces a single point of failure for any application relying on the SGW for a file storage

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sansns sansns requested review from a team as code owners October 29, 2024 17:37
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.88%. Comparing base (8a6e222) to head (4b90eb3).
Report is 131 commits behind head on master.

Files with missing lines Patch % Lines
.../services/storagegateway/storagegateway_service.py 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5570      +/-   ##
==========================================
+ Coverage   89.78%   89.88%   +0.09%     
==========================================
  Files        1090     1133      +43     
  Lines       33767    35312    +1545     
==========================================
+ Hits        30318    31739    +1421     
- Misses       3449     3573     +124     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCloudSec
Copy link
Member

Hi @sansns, I have made several changes on the check. Let me know what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants