Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws): add new service firehose #5620

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

HugoPBrito
Copy link
Member

Context

Until now Prowler didn't support AWS Data Firehose service.

Description

Created Firehose service within AWS Prowler services to be able to implement its checks.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HugoPBrito HugoPBrito requested review from a team as code owners November 4, 2024 12:16
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.87%. Comparing base (bf91113) to head (b3ad851).
Report is 84 commits behind head on master.

Files with missing lines Patch % Lines
...roviders/aws/services/firehose/firehose_service.py 87.09% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5620      +/-   ##
==========================================
+ Coverage   89.75%   89.87%   +0.11%     
==========================================
  Files        1104     1128      +24     
  Lines       34274    35154     +880     
==========================================
+ Hits        30762    31593     +831     
- Misses       3512     3561      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCloudSec MrCloudSec self-requested a review November 12, 2024 21:18
@MrCloudSec MrCloudSec merged commit dca49b1 into master Nov 12, 2024
10 of 11 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-5148-create-firehose-service branch November 12, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants