Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firehose): add new check firehose_stream_encrypted_at_rest #5635

Conversation

HugoPBrito
Copy link
Member

Context

Amazon Kinesis Data Firehose is a fully managed service for loading real-time streaming data into data lakes, data stores, and analytics services. For data security, AWS provides server-side encryption (SSE), which encrypts data at rest within the storage layer using keys from AWS Key Management Service (KMS). This ensures that any data written to Kinesis Firehose is encrypted before storage, helping to protect sensitive information and meet compliance standards.

Description

This check ensures that Amazon Kinesis Data Firehose delivery streams have server-side encryption enabled for data at rest. The check fails if a delivery stream is unencrypted, which means that the data stored within Firehose could be accessed without encryption safeguards.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HugoPBrito HugoPBrito requested review from a team as code owners November 5, 2024 11:09
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 95.12195% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.87%. Comparing base (3608aa3) to head (9ded480).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...roviders/aws/services/firehose/firehose_service.py 90.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5635      +/-   ##
==========================================
- Coverage   89.91%   89.87%   -0.04%     
==========================================
  Files        1128     1130       +2     
  Lines       35180    35224      +44     
==========================================
+ Hits        31631    31659      +28     
- Misses       3549     3565      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCloudSec MrCloudSec merged commit c1b050b into master Nov 14, 2024
10 of 11 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-4465-ensure-firehose-delivery-streams-are-encrypted-at-rest branch November 14, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants