Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(azure): get locations with self session #5751

Merged

Conversation

pedrooot
Copy link
Member

Description

This pull request includes changes to the azure_provider.py file within the prowler/providers/azure directory. The main focus of these changes is to simplify the get_locations method by removing the need to pass credentials as an argument and instead using the session directly.

Key changes include:

  • Simplification of the __init__ method by removing the credentials argument from the get_locations method call.
  • Modification of the get_locations method to no longer require credentials as an argument and directly use the session for authentication.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot requested review from a team as code owners November 13, 2024 13:43
@github-actions github-actions bot added the provider/azure Issues/PRs related with the Azure provider label Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 89.91%. Comparing base (5641160) to head (bfe4d6d).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
prowler/providers/azure/azure_provider.py 22.22% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5751      +/-   ##
==========================================
+ Coverage   89.83%   89.91%   +0.07%     
==========================================
  Files        1128     1128              
  Lines       35154    35152       -2     
==========================================
+ Hits        31582    31606      +24     
+ Misses       3572     3546      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

prowler/providers/azure/azure_provider.py Outdated Show resolved Hide resolved
prowler/providers/azure/azure_provider.py Show resolved Hide resolved
prowler/providers/azure/azure_provider.py Outdated Show resolved Hide resolved
jfagoagas
jfagoagas previously approved these changes Nov 13, 2024
@jfagoagas jfagoagas merged commit 06b41cf into master Nov 13, 2024
10 of 11 checks passed
@jfagoagas jfagoagas deleted the PRWLR-5351-azure-add-a-way-to-get-the-regions-by-partition branch November 13, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/azure Issues/PRs related with the Azure provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants