Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to return VMEC++ outputs even if the run did not converge. #84

Merged
merged 3 commits into from
Mar 5, 2025
Merged

Allow to return VMEC++ outputs even if the run did not converge. #84

merged 3 commits into from
Mar 5, 2025

Conversation

jons-pf
Copy link
Collaborator

@jons-pf jons-pf commented Feb 6, 2025

No description provided.

@jons-pf Graphite App
Copy link
Collaborator Author

jons-pf commented Feb 6, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Feb 6, 2025
Merged
Open
Open
@jons-pf jons-pf force-pushed the jons-vmecpp-return-results-even-if-not-converged-2 branch from 294a184 to 1585d87 Compare February 6, 2025 15:07
@jons-pf jons-pf requested a review from eguiraud-pf February 6, 2025 15:18
@graphite-app Graphite App
Copy link

graphite-app bot commented Feb 10, 2025 •
edited by jons-pf
Loading

Merge activity

  • Feb 10, 5:36 AM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Mar 5, 11:35 AM EST: A user merged this pull request with Graphite.

@jons-pf jons-pf force-pushed the jons-vmecpp-return-results-even-if-not-converged-2 branch 2 times, most recently from 0026851 to 7f01603 Compare February 14, 2025 13:20
@eguiraud-pf eguiraud-pf removed their request for review February 14, 2025 13:51
@jons-pf jons-pf force-pushed the jons-vmecpp-return-results-even-if-not-converged-2 branch 3 times, most recently from 965e313 to 6346582 Compare February 14, 2025 14:05
@jons-pf jons-pf requested a review from eguiraud-pf February 14, 2025 14:07
@jons-pf jons-pf force-pushed the jons-vmecpp-return-results-even-if-not-converged-2 branch 3 times, most recently from 429c3cd to 080516e Compare February 19, 2025 06:55
eguiraud-pf
eguiraud-pf approved these changes Feb 24, 2025
View reviewed changes
@jons-pf jons-pf force-pushed the jons-vmecpp-return-results-even-if-not-converged-2 branch from ff5f2f2 to 3118ba7 Compare March 5, 2025 15:42
@jons-pf jons-pf merged commit 5676d3f into main Mar 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eguiraud-pf eguiraud-pf eguiraud-pf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jons-pf @eguiraud-pf