WI_SWITCH_t : Ensure that variable "index" is private, preventing use outside the derived class #4177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CZDanol
requested changes
Sep 2, 2024
There was a problem hiding this comment.
See #4176 for first commit issues. The correct solution would be to do:
SetIndex(netdev_get_ip_obtained_type(this->device_id()));
instead of
index = netdev_get_ip_obtained_type(this->device_id());
Also, this will need to be changed on more places to make other build targets to build.
bkerler
force-pushed
the
wswitch_index_fixes
branch
2 times, most recently
from
50eca04
to
a36bba8
Compare
|
Updated, looks like it does build fine now :) |
bkerler
changed the title
bkerler
force-pushed
the
wswitch_index_fixes
branch
from
a36bba8
to
1c354ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuse of the variable "index" within a WI_SWITCH_t derived class can lead to issues as the variable "index" might be used outside the WI_SWITCH_t class and could interfer with the derived class index value, thus leading to functionality issues. By redefining index as private variable in WI_SWITCH_t and making usage of the defined GetIndex/SetIndex functions, similar issues can be prevented in the future.