Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup dependencies #4221

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ysmilda
Copy link
Contributor

@ysmilda ysmilda commented Sep 24, 2024

Closes #4195

This pull request updates the various dependencies to the latest versions. These updates bring support for using this codebase on ARM devices.

The following dependencies are updated:

  • clang-format 16 > 18.1.8 (19.1 has been released, but binaries not yet available)
  • ninja 1.10.2 > 1.12.1
  • cmake 3.28.3 > 3.30.3

An update for gcc-arm-none-eabi is available, but still working through some issues when used from ARM devices.

This is still in development, but anyone wanting to help out and test the various integrations is more than welcome!

@CZDanol
Copy link
Contributor

CZDanol commented Sep 25, 2024

Unittests CI failing: /work/.dependencies/cmake-3.28.3/bin/ctest: not found

@ysmilda
Copy link
Contributor Author

ysmilda commented Sep 25, 2024

That's weird. It seems to use an old config as I did update the build-pr.jenkins file to target the new binaries.

@CZDanol
Copy link
Contributor

CZDanol commented Sep 25, 2024

My guess would be that we have it hardcoded on some more places :/

@ysmilda
Copy link
Contributor Author

ysmilda commented Sep 25, 2024

Can't check it anymore as the build seems to have been deleted. But from what I could gather from the output and the related jenkins file it did get stuck on the line I referenced above. Would it be possible to do a rerun and see if it picks up the changes?

@CZDanol
Copy link
Contributor

CZDanol commented Sep 26, 2024

Allright, issuing a rerun :)

@ysmilda
Copy link
Contributor Author

ysmilda commented Sep 26, 2024

Can't see the result, but it seems to have failed again (which isn't a big surprise). Is all the config for holly/jenkins contained within the repo or are there other sources that need updating?

@CZDanol
Copy link
Contributor

CZDanol commented Sep 26, 2024

Afaik it should all be in the repo itself. @danopernis am I right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Bundled version of clang-format broken on ARM Apple devices
2 participants