Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap filename with 'anywhere' behavior #433

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

dunkmann00
Copy link
Contributor

Rather than having the filename run on for one line even when it is particularly long (as is commonly the case with gcode filenames). Have the filename wrap into another line. This works on both desktop and mobile layouts with a big improvement to the look of the webpage on mobile.

Before:
Prusalink_no_wrap

After:
192 168 86 95_(iPhone 12 Pro)

Rather than having the filename run on for one line even when it is
particularly long (as is commonly the case with gcode filenames). Have
the filename wrap into another line. This works on both desktop and
mobile layouts with a big improvement to the look of the webpage on
mobile.
@dunkmann00
Copy link
Contributor Author

I think the secrets (PRUSALATOR_SERVER, PRUSALATOR_PROJECT_ID, PRUSALATOR_TOKEN) did not get passed into the workflow.

And I also believe this is intentional:

With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository.

Source: https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions#using-secrets-in-a-workflow

@ondratu ondratu merged commit f7fa76d into prusa3d:master Sep 8, 2023
0 of 3 checks passed
@dunkmann00
Copy link
Contributor Author

Thanks!

@dunkmann00 dunkmann00 deleted the wrap-filename branch September 8, 2023 15:57
dunkmann00 added a commit to dunkmann00/Prusa-Firmware-Buddy that referenced this pull request Sep 11, 2023
This includes the updated behavior from
prusa3d/Prusa-Link-Web#433 which changes the
filename wrapping behavior to 'anywhere'.
dunkmann00 added a commit to dunkmann00/Prusa-Firmware-Buddy that referenced this pull request Sep 11, 2023
This includes the updated behavior from
prusa3d/Prusa-Link-Web#433 which changes the
filename wrapping behavior to 'anywhere'.
dunkmann00 added a commit to dunkmann00/Prusa-Firmware-Buddy that referenced this pull request Sep 18, 2023
This includes the updated behavior from
prusa3d/Prusa-Link-Web#433 which changes the
filename wrapping behavior to 'anywhere'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants