Add GET /eth/v2/beacon/pool/attestations endpoint
#14560
+474
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saolyn
changed the title
/eth/v2/beacon/pool/attestations endpoint
saolyn
changed the title
/eth/v2/beacon/pool/attestations endpointGET /eth/v2/beacon/pool/attestations endpoint
saolyn
requested review from
nalepae,
prestonvanloon,
potuz,
rkapka and
james-prysm
saolyn
force-pushed
the
add-getAttestations
branch
from
c43e5ba
to
33a2948
Compare
james-prysm
reviewed
Oct 22, 2024
james-prysm
reviewed
Oct 22, 2024
| case *eth.AttestationElectra: | ||
| allAtts[i] = structs.AttElectraFromConsensus(a) | ||
| if !versionSet { | ||
| firstVersion = a.Version() |
There was a problem hiding this comment.
instead of doing this first version set etc, can't we get the fork from the slot?
There was a problem hiding this comment.
same with the other function
james-prysm
reviewed
Oct 22, 2024
| } else { | ||
| bothDefined := rawSlot != "" && rawCommitteeIndex != "" | ||
| filteredAtts := make([]interface{}, 0, len(attestations)) | ||
| for _, att := range attestations { |
There was a problem hiding this comment.
I think there should be a way to merge these two loops and just append based on these checks right?
rkapka
reviewed
Oct 23, 2024
Comment on lines
81
to
84
| committeeIndexMatch := rawCommitteeIndex != "" && att.GetData().CommitteeIndex == primitives.CommitteeIndex(committeeIndex) | ||
| slotMatch := rawSlot != "" && att.GetData().Slot == primitives.Slot(slot) | ||
| shouldAppend := (bothDefined && committeeIndexMatch && slotMatch) || (!bothDefined && (committeeIndexMatch || slotMatch)) | ||
| if shouldAppend { |
There was a problem hiding this comment.
I think this can be simplified like this:
committeeIndexMatch := true
slotMatch := true
if rawCommitteeIndex != "" && att.GetData().CommitteeIndex != primitives.CommitteeIndex(committeeIndex) {
committeeIndexMatch = false
}
if rawSlot != "" && att.GetData().Slot != primitives.Slot(slot) {
slotMatch = false
}
if committeeIndexMatch && slotMatch {
rkapka
reviewed
Oct 23, 2024
| } else { | ||
| httputil.HandleError(w, fmt.Sprintf("unable to convert attestations of type %T", att), http.StatusInternalServerError) | ||
| if !ok { | ||
| httputil.HandleError(w, fmt.Sprintf("Unable to convert attestations of type %T", att), http.StatusInternalServerError) |
There was a problem hiding this comment.
Suggested change
| httputil.HandleError(w, fmt.Sprintf("Unable to convert attestations of type %T", att), http.StatusInternalServerError) | |
| httputil.HandleError(w, fmt.Sprintf("Unable to convert attestation of type %T", att), http.StatusInternalServerError) |
rkapka
reviewed
Oct 23, 2024
| if shouldAppend { | ||
| a, ok := att.(*eth.Attestation) | ||
| if !ok { | ||
| httputil.HandleError(w, fmt.Sprintf("Unable to convert attestations of type %T", att), http.StatusInternalServerError) |
There was a problem hiding this comment.
Suggested change
| httputil.HandleError(w, fmt.Sprintf("Unable to convert attestations of type %T", att), http.StatusInternalServerError) | |
| httputil.HandleError(w, fmt.Sprintf("Unable to convert attestation of type %T", att), http.StatusInternalServerError) |
rkapka
reviewed
Oct 23, 2024
| } | ||
| httputil.WriteJson(w, &structs.ListAttestationsResponse{Data: filteredAtts}) | ||
| w.Header().Set(api.VersionHeader, version.String(firstVersion)) |
There was a problem hiding this comment.
Same idea as for slashings: we should use the head state or current slot to determine the version and only return attestations for that version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
Beacon API Electra alignment, add missing endpoint for GET
/eth/v2/beacon/pool/attestations.As described in the spec https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Beacon/getPoolAttestationsV2
Which issues(s) does this PR fix?
Part of #14476
Other notes for review
Acknowledgements