removing unnecessary reconnections to el #14567
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cacheHeadersForEth1DataVote --> followedBlockHeight --> BlockByTimestamp --> retrieveHeaderInfo --> HeaderByNumber --> s.rpcClient.CallContext was missed in this, instead i should be adding some kind of error wrapper and checking if the error requires a reconnection |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
We shouldn't be trying to reconnect to the execution client when there isn't a call via RPC to the execution client. Instead we should just continue and retry without reconnections.
Which issues(s) does this PR fix?
Fixes ( in part) #14226
Other notes for review
Acknowledgements