-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracked validators metric #14575
base: develop
Are you sure you want to change the base?
Tracked validators metric #14575
Conversation
func (t *TrackedValidatorsCache) Size() int { | ||
t.Lock() | ||
defer t.Unlock() | ||
return len(t.trackedValidators) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could it be beneficial to add a note directly to the code that the accuracy of this is not 100%?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this does return the size of the cache, it's more that the metric might not be fully representative
PR is in discussion |
What type of PR is this?
Other
What does this PR do? Why is it needed?
introduces a new metric for current tracked validators on the beacon node. the accuracy of this is not 100% in this basic metric as the tracked validators cache is not pruned for removed validators that have not been consistently tracked.
Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements