Tracked validators metric #14575
Open
Tracked validators metric #14575
+27
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saolyn
reviewed
Oct 24, 2024
Comment on lines
+51
to
+55
| func (t *TrackedValidatorsCache) Size() int { | ||
| t.Lock() | ||
| defer t.Unlock() | ||
| return len(t.trackedValidators) | ||
| } |
There was a problem hiding this comment.
Could it be beneficial to add a note directly to the code that the accuracy of this is not 100%?
There was a problem hiding this comment.
this does return the size of the cache, it's more that the metric might not be fully representative
saolyn
approved these changes
Oct 25, 2024
|
PR is in discussion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
introduces a new metric for current tracked validators on the beacon node. the accuracy of this is not 100% in this basic metric as the tracked validators cache is not pruned for removed validators that have not been consistently tracked.
Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements