Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache uses wrong seen committee index for electra #14998

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

cache uses wrong seen committee index for electra #14998

wants to merge 3 commits into from
+69 −1

Conversation

james-prysm
Copy link
Contributor

@james-prysm james-prysm commented Feb 27, 2025 •
edited
Loading

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

PR fixes a small bug with using the wrong committee index for electra attestations. adds some unit tests as well.

Which issues(s) does this PR fix?

Fixes #

Other notes for review

Acknowledgements

@james-prysm james-prysm added Bug Something isn't working Electra electra hardfork labels Feb 27, 2025
@james-prysm james-prysm requested a review from a team as a code owner February 27, 2025 21:34
@james-prysm james-prysm mentioned this pull request Feb 27, 2025
Open
3 tasks
rkapka
rkapka requested changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@rkapka rkapka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass with the old code, so they are not actually testing anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkapka rkapka rkapka requested changes

@nisdas nisdas nisdas approved these changes

@kasey kasey Awaiting requested review from kasey kasey is a code owner automatically assigned from prysmaticlabs/core-team

@nalepae nalepae Awaiting requested review from nalepae nalepae is a code owner automatically assigned from prysmaticlabs/core-team

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon prestonvanloon is a code owner automatically assigned from prysmaticlabs/core-team

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Bug Something isn't working Electra electra hardfork
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@james-prysm @rkapka @nisdas