Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Italian #21

Merged
merged 4 commits into from
Jan 18, 2025
Merged

Update Italian #21

merged 4 commits into from
Jan 18, 2025

Conversation

vanmatten
Copy link
Contributor

@vanmatten vanmatten commented Jan 14, 2025

Updated Italian translation following template guidelines (https://github.com/ps2homebrew/Open-PS2-Loader/blob/master/lng_tmpl/_base.yml). Implement requested edit to PR #12
Added new strings from template.
Fixed/improved some strings.

Update translation following template guidelines (https://github.com/ps2homebrew/Open-PS2-Loader/blob/master/lng_tmpl/_base.yml).
Added new strings from template.
Fixed/improved some strings.
Italian.yml Outdated
@@ -13,22 +13,20 @@ translations:
EXIT: Esci
SETTINGS: Impostazioni
MENU:
- untranslated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erm? Same?

Copy link
Contributor Author

@vanmatten vanmatten Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the main repo template It is indicated as below:

Entry that is intentionally left untranslated looks like this:
LABEL:
- same
- original: Version of this string in English

Entry that is not yet translated looks like this:
LABEL:
- untranslated
- original: Version of this string in English

If it's not correct I suggest to change it to have unified guidelines for translation.

Let me know if I have to restore same with untranslated.
Edit: restored untranslated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is correct, but are you sure that Italian language has so many English words that it uses natively?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't call 14 strings out of 326 so many!
In the field of computer science several English words are used. Moreover, literaly translating strings could cause to have an unclear UI, even if some word has its own translation.

I restored untranslated label, I don't think it's so important to have the same label. However I'm sure about the strings that don't need translation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nah, its nice, I just want to be sure that you didn't set label "same" by mistake. If English word suits better in some cases, it is better to set "same for sure.

@AKuHAK AKuHAK merged commit bc62cdf into ps2homebrew:main Jan 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants