-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean commandline options and references to network #46
base: master
Are you sure you want to change the base?
Conversation
A little cleaning before the release! |
mmm, are you sure that this should be removed? Some people still use hdl_srv_093.elf for installing. NBD isn't an option for MacOS users for example |
They can still use old release, that what they did anyway, still using old 093 exe. i just would like a massive cleanup on this tool, and i start by where this created confusion for users (as for example, poweroff is not available on nbd). Some people don't want to move forward, that shouldn't slow down others. candidates for deletion: EDIT: Part of the point of writing lwNBD was also to simplify this tool to make it easier to maintain. By reducing the code coverage, it also simplifies refactoring and test coverage of the code... |
is directory execli something relevant in 2022 ? |
I still dont think that cutting off network is not a good idea, specially comparing with current speed in nbd implementation. Currently hdl_dump with srvr 0.9.3 is the fastest way to transfer. |
I still think NBD would triumph over his conccurent and hdl_dump would benefit from stripped sources. In the stat of the project, i often ask myself if it worth the time spent and we don't have many contributors wanted to ride old kind of source. I prefer try time to time pushing, remember that no release means no release support in linux distrib, no life visibility on forum / news. i won't fight. For example, for populating large zeroed partition for linux and so, if i implement CMD_WRITE_ZEROES, lwnbd would be more efficient, on such task. Usage matter, letting old release and old server be the norm doesn't help here. |
Like the rest, I am never followed on my stuff. I'd close that PR. |
Pull Request checklist
Note: these are not necessarily requirements
Pull Request description