Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Don't merge] Use sio2man/padman from ps2sdk #41

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

uyjulian
Copy link
Member

Pull Request checklist

Note: these are not necessarily requirements

  • I reformatted the code with clang-format
  • I checked to make sure my submission worked
  • I am the author of submission or have permission from the original author
  • Requires update of the PS2SDK
  • Requires update of the gsKit
  • Others (please specify below)

Pull Request description

Use sio2man/padman from ps2sdk

@sp193
Copy link
Collaborator

sp193 commented Jul 20, 2020

I attempted this before. If you do this, then you will break compatibility with homebrew that:

  • Do not reboot the IOP and expect the necessary modules to be loaded.
  • Are built to work with the default IOP modules. Particularly the original MCMAN, MCSERVE, SIO2MAN and PADMAN.

This is a problem for LaunchELF's current design, as the IOP modules used within the UI are also the ones that exist when a piece of software is loaded.

@uyjulian
Copy link
Member Author

I can probably add a IOP reboot with the old configuration before executing the ELF…

@uyjulian
Copy link
Member Author

Added compatible reset functionality.

@AKuHAK
Copy link
Member

AKuHAK commented Jan 6, 2021

Looks good to me. If I understand logic correctly, wLe itself will use modules from SDK. But when launching elf it will perform an additional reset which replicates the current wLe state.
@uyjulian
Just to be sure - now ELF launch will take a longer time (as the reset function isn't that fast)? Did it break launch arguments when launching the new ELF?
Do you want to add something else in PR? It is already pretty old maybe you have new ideas?

@AKuHAK AKuHAK self-requested a review January 6, 2021 10:54
Copy link
Member

@AKuHAK AKuHAK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, however, it will be better to test the changes.

@uyjulian
Copy link
Member Author

I think I might attempt to move the module loading to before the screen is blanked, so the user knows that the IOP is reloading.

@uyjulian
Copy link
Member Author

I moved the reboot location to before the screen is cleared, and added an additional message specifying that the IOP is being rebooted.

However, I don't have hardware or the environment setup right now to test this functionality, so please check it.

@AKuHAK
Copy link
Member

AKuHAK commented Jun 20, 2021

@uyjulian console and pcsx2 just freeze after "Rebooting iop in compatibility mode."

@uyjulian
Copy link
Member Author

It looks like a ps2sdk update may have caused the black screen issue… I may bisect it later

@uyjulian
Copy link
Member Author

The issue has been found: #59

@uyjulian uyjulian force-pushed the ps2sdkmodules branch 3 times, most recently from 8ab82b1 to 239fac8 Compare June 22, 2021 04:36
@AKuHAK
Copy link
Member

AKuHAK commented Jun 22, 2021

The issue has been found: #59

However, this PR still produces a black screen.

@uyjulian
Copy link
Member Author

Since I added backwards compatible RPC to sio2man and padman to ps2sdk, I removed the reboot code.

@AKuHAK
Copy link
Member

AKuHAK commented Jun 30, 2021

dont know if we should try to fix ps2eth, or I just roll back github action to 1.3.0

@uyjulian
Copy link
Member Author

I already submitted a PR to fix ps2eth.

@uyjulian uyjulian marked this pull request as draft March 19, 2022 00:16
@uyjulian uyjulian changed the title Use sio2man/padman from ps2sdk [Don't merge] Use sio2man/padman from ps2sdk Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants