-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Don't merge] Use sio2man/padman from ps2sdk #41
base: master
Are you sure you want to change the base?
Conversation
I attempted this before. If you do this, then you will break compatibility with homebrew that:
This is a problem for LaunchELF's current design, as the IOP modules used within the UI are also the ones that exist when a piece of software is loaded. |
I can probably add a IOP reboot with the old configuration before executing the ELF… |
Added compatible reset functionality. |
Looks good to me. If I understand logic correctly, wLe itself will use modules from SDK. But when launching elf it will perform an additional reset which replicates the current wLe state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, however, it will be better to test the changes.
I think I might attempt to move the module loading to before the screen is blanked, so the user knows that the IOP is reloading. |
I moved the reboot location to before the screen is cleared, and added an additional message specifying that the IOP is being rebooted. However, I don't have hardware or the environment setup right now to test this functionality, so please check it. |
@uyjulian console and pcsx2 just freeze after "Rebooting iop in compatibility mode." |
It looks like a ps2sdk update may have caused the black screen issue… I may bisect it later |
The issue has been found: #59 |
8ab82b1
to
239fac8
Compare
However, this PR still produces a black screen. |
Since I added backwards compatible RPC to sio2man and padman to ps2sdk, I removed the reboot code. |
dont know if we should try to fix ps2eth, or I just roll back github action to 1.3.0 |
I already submitted a PR to fix ps2eth. |
87d9734
to
5f4ba1b
Compare
5f4ba1b
to
4dc9c92
Compare
Pull Request checklist
Note: these are not necessarily requirements
Pull Request description
Use sio2man/padman from ps2sdk