Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement LDAP check integration #94

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

implement LDAP check integration #94

wants to merge 24 commits into from

Conversation

memsdm05
Copy link

Fixes #37

ajkiessl
ajkiessl requested changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@ajkiessl ajkiessl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. The only thing I think we should add is some documentation to the main page ('main/index.html.erb'). A little something about how the CSV should be formatted and what the process does.

memsdm05
memsdm05 commented Feb 14, 2025
View reviewed changes
Copy link
Author

@memsdm05 memsdm05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

ajkiessl
ajkiessl approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@ajkiessl ajkiessl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajkiessl ajkiessl ajkiessl approved these changes

@Smullz622 Smullz622 Awaiting requested review from Smullz622

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LDAP Check
2 participants
@memsdm05 @ajkiessl