Open Edition minter update & tests #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #629 +/- ##
==========================================
+ Coverage 60.07% 60.10% +0.03%
==========================================
Files 83 83
Lines 4518 4582 +64
==========================================
+ Hits 2714 2754 +40
- Misses 1804 1828 +24 ☔ View full report in Codecov by Sentry. |
Cosm-Orc Gas Usage
Raw Report for 451c6ac
|
tasiov
approved these changes
Dec 13, 2023
| @@ -193,10 +200,20 @@ pub fn execute_purge( | |||
| info: MessageInfo, | |||
| ) -> Result<Response, ContractError> { | |||
| nonpayable(&info)?; | |||
| // Check if mint has ended | |||
| // check if sold out (optional) | |||
| let mintable_num_tokens = MINTABLE_NUM_TOKENS.may_load(deps.storage)?; | |||
There was a problem hiding this comment.
so what if it's ended but not sold out?
There was a problem hiding this comment.
mintable_num_tokens is only Some when there is no end time defined (as per instantiation), so the minting cannot be time limited in this case.
| @@ -11,8 +11,9 @@ pub struct ConfigExtension { | |||
| pub payment_address: Option<Addr>, | |||
| pub nft_data: NftData, | |||
| pub start_time: Timestamp, | |||
| pub end_time: Timestamp, | |||
| pub end_time: Option<Timestamp>, | |||
There was a problem hiding this comment.
curious if this will cause errors on read
There was a problem hiding this comment.
The contract will be used for new open edition collections onwards without any migrations. It could cause indexing errors though if not accounted for.
jhernandezb
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the user to set a limit for the number of tokens instead of a limit for minting end time.