Pages tagged with place get a full-width map across the top of the page (instead of in the sidebar) #5518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
11 tasks
|
This looks FANTASTIC! This has gotten broken a few times... do you think you could write a simple system test for it? #5316 Then we can protect it against future changes? I think it could be pretty easy to add. Thank you!!! |
|
Okay |
|
Tests passed ❤️ . Ready to be merged . |
|
PERFECT awesome. |
jywarren
reviewed
Apr 25, 2019
| class PlaceTagsTest < ApplicationSystemTestCase | ||
|
|
||
| # node blog has lat and lon tag and place tag . | ||
| test "pages tagged with place get a full-width map across the top of the page" do |
There was a problem hiding this comment.
Hey, @sagarpreet-chadha can you see if I'm doing anything wrong here? #5605
SrinandanPai
pushed a commit
to SrinandanPai/plots2
that referenced
this pull request
May 5, 2019
…age (instead of in the sidebar) (publiclab#5518) * full width map from sidebar * indentation done * code climate issue fixed * system test added * system test added * system test modification * assert presence of div * assert_selector used * tests modified
digitaldina
pushed a commit
to digitaldina/plots2
that referenced
this pull request
May 12, 2019
…age (instead of in the sidebar) (publiclab#5518) * full width map from sidebar * indentation done * code climate issue fixed * system test added * system test added * system test modification * assert presence of div * assert_selector used * tests modified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued from publiclab/leaflet-blurred-location-display#64 (comment) 😄 !
rake test@publiclab/reviewersfor help, in a comment belowScreenshots :
placetag :placetag :Thanks!