Add the ability to switch transport API #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the browser version of PubNub SDK, add the ability to switch between `fetch` and `xhr` APIs (`transport` configuration option). fix(event-engine): handshake/receive requests timeout Fix issue because of which, in Event Engine mode, wrong timeout values have been set for requests which create long-poll request. refactor(request): make sure request cancels on timeout Refactor `timeout` implementation for `fetch` transport to properly cancel request when the timeout timer will fire.
parfeon
added
status: done
mohitpubnub
approved these changes
Feb 5, 2025
| @@ -118,6 +132,7 @@ export const setDefaults = (configuration: PubNubConfiguration): PubNubConfigura | |||
| listenToBrowserNetworkEvents: configuration.listenToBrowserNetworkEvents ?? LISTEN_TO_BROWSER_NETWORK_EVENTS, | |||
| subscriptionWorkerUrl: configuration.subscriptionWorkerUrl, | |||
| subscriptionWorkerLogVerbosity: configuration.subscriptionWorkerLogVerbosity ?? SUBSCRIPTION_WORKER_LOG_VERBOSITY, | |||
| transport: configuration.transport ?? TRANSPORT, | |||
| * | ||
| * @default `fetch` | ||
| */ | ||
| transport?: 'fetch' | 'xhr'; |
| */ | ||
| private async sendXHRRequest(req: WebTransportRequest, controller: WebCancellationController): Promise<Response> { | ||
| return new Promise<Response>((resolve, reject) => { | ||
| const xhr = new XMLHttpRequest(); |
There was a problem hiding this comment.
Here we go again!!!! :(
There was a problem hiding this comment.
It is a backup for really messed up case with APM tools and some weird browser restrictions which maybe enforced... fetch is shiny and better :)
|
@pubnub-release-bot release |
pubnub-release-bot
requested review from
techwritermat and
kazydek
as code owners
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(transport): add the ability to switch transport API
For the browser version of PubNub SDK, add the ability to switch between
fetchandxhrAPIs (transportconfiguration option).fix(event-engine): handshake/receive requests timeout
Fix issue because of which, in Event Engine mode, wrong timeout values have been set for requests which create long-poll request.
refactor(request): make sure request cancels on timeout
Refactor
timeoutimplementation forfetchtransport to properly cancel request when the timeout timer will fire.