Fix for invalid meta casting #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkal-pubnub
reviewed
Aug 26, 2024
| @@ -85,7 +85,7 @@ data class ThreadMessageImpl( | |||
| channelId = channelId, | |||
| userId = messageItem.uuid!!, | |||
| actions = messageItem.actions, | |||
| meta = messageItem.meta?.decode()?.let { it as Map<String, Any>? }, | |||
| meta = messageItem.meta?.decode()?.let { it as? Map<String, Any>? }, | |||
There was a problem hiding this comment.
just to understand more, can it be anything else than a Map when it's not null in normal chat operation?
There was a problem hiding this comment.
In theory, I believe we could pass any JSON object we want, not just a Map. Moreover, the meta type, whether it's a Dictionary or not, should be consistent across all Chat platforms.
I just noticed that this casting will always fail if meta is nil. The fromDTO method, which is declared above the method I've corrected, has appropriate casting.
wkal-pubnub
approved these changes
Aug 26, 2024
|
please run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.