Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for invalid meta casting #61

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Fix for invalid meta casting #61

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90abdea
Fix for invalid casting
jguz-pubnub Aug 26, 2024
afc3a8b
Fix for extracting quotedMessage
jguz-pubnub Aug 26, 2024
cebc93c
Fixed linter issues
jguz-pubnub Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pubnub-chat-impl/src/commonMain/kotlin/com/pubnub/chat/internal/message/ThreadMessageImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ data class ThreadMessageImpl(
channelId = channelId,
userId = messageItem.uuid!!,
actions = messageItem.actions,
meta = messageItem.meta?.decode()?.let { it as Map<String, Any>? },
meta = messageItem.meta?.decode()?.let { it as? Map<String, Any>? },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to understand more, can it be anything else than a Map when it's not null in normal chat operation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory, I believe we could pass any JSON object we want, not just a Map. Moreover, the meta type, whether it's a Dictionary or not, should be consistent across all Chat platforms.

I just noticed that this casting will always fail if meta is nil. The fromDTO method, which is declared above the method I've corrected, has appropriate casting.

mentionedUsers = messageItem.meta.extractMentionedUsers(),
referencedChannels = messageItem.meta.extractReferencedChannels(),
quotedMessage = messageItem.meta?.let { PNDataEncoder.decode(it) },
Expand Down
Loading