Mc/restore #56
Merged
Mc/restore #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcin-cebo
force-pushed
the
mc/restore
branch
from
4fb1b73 to
0123bc4
Compare
marcin-cebo
commented
Aug 16, 2024
| updatedActions = actions!!.filterNot { it.key == chat.deleteMessageActionName } | ||
| }.thenAsync { | ||
| // get messageAction for all messages in channel | ||
| chat.pubNub.getMessageActions(channel = channelId, page = PNBoundedPage(end = timetoken)) |
There was a problem hiding this comment.
This is coded differently that in TS. There is a bug in TS because calling getMessageActions
one can provide start/end that refers to actionTimetoken not messageTimetoken
I informed Piotrek about this and proposed solution that I implemented in KMP
wkal-pubnub
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.