Fix parameter name in manageChannelMembers

pubnub · Dec 5, 2024 · 92958e2 · 92958e2
1 parent be20f9e
commit 92958e2
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/...java/com/pubnub/internal/java/endpoints/objects_api/members/ManageChannelMembersImpl.java b/...java/com/pubnub/internal/java/endpoints/objects_api/members/ManageChannelMembersImpl.java
@@ -46,7 +46,7 @@ public class ManageChannelMembersImpl extends DelegatingEndpoint<PNMemberArrayRe
     private Collection<PNUUID> uuidsToSet; // deprecated
     private Collection<PNUUID> uuidsToRemove; // deprecated
     private Collection<PNUser> usersToSet;
-    private List<String> usersIdsToRemove;
+    private List<String> userIdsToRemove;
     private MemberInclude include;
 
     @Deprecated
@@ -57,11 +57,11 @@ public ManageChannelMembersImpl(String channel, Collection<PNUUID> uuidsToSet, C
         this.uuidsToRemove = uuidsToRemove;
     }
 
-    public ManageChannelMembersImpl(final PubNub pubnubInstance, String channel, Collection<PNUser> usersToSet, Collection<String> usersIdsToRemove) {
+    public ManageChannelMembersImpl(final PubNub pubnubInstance, String channel, Collection<PNUser> usersToSet, Collection<String> userIdsToRemove) {
         super(pubnubInstance);
         this.channel = channel;
         this.usersToSet = usersToSet;
-        this.usersIdsToRemove = new ArrayList<>(usersIdsToRemove);
+        this.userIdsToRemove = new ArrayList<>(userIdsToRemove);
     }
 
     @NotNull
@@ -77,9 +77,9 @@ protected Endpoint<PNMemberArrayResult> createRemoteAction() {
         List<String> toRemove;
 
         // new API use
-        if (usersToSet != null || usersIdsToRemove != null) {
+        if (usersToSet != null || userIdsToRemove != null) {
             toSet = createMemberInputFromUserToSet();
-            toRemove = usersIdsToRemove;
+            toRemove = userIdsToRemove;
         } else { // old API used
             toSet = createMemberInputFromUUIDToSet();
             toRemove = createUserIdsFromUUIDToRemove();

diff --git a/pubnub-kotlin/pubnub-kotlin-api/src/jvmMain/kotlin/com/pubnub/api/PubNub.kt b/pubnub-kotlin/pubnub-kotlin-api/src/jvmMain/kotlin/com/pubnub/api/PubNub.kt
@@ -1868,7 +1868,7 @@ actual interface PubNub : StatusEmitter, EventEmitter {
      *
      * @param channel Channel name
      * @param usersToSet Collection of members to add to the channel. @see [com.pubnub.api.models.consumer.objects.member.PNMember.Partial]
-     * @param usersIdsToRemove Members to remove from channel.
+     * @param userIdsToRemove Members to remove from channel.
      * @param limit Number of objects to return in the response.
      *              Default is 100, which is also the maximum value.
      *              Set limit to 0 (zero) and includeCount to true if you want to retrieve only a result count.
@@ -1886,7 +1886,7 @@ actual interface PubNub : StatusEmitter, EventEmitter {
     fun manageChannelMembers(
         channel: String,
         usersToSet: Collection<MemberInput>,
-        usersIdsToRemove: Collection<String>,
+        userIdsToRemove: Collection<String>,
         limit: Int? = null,
         page: PNPage? = null,
         filter: String? = null,

diff --git a/...tlin-impl/src/integrationTest/kotlin/com/pubnub/api/integration/ObjectsIntegrationTest.kt b/...tlin-impl/src/integrationTest/kotlin/com/pubnub/api/integration/ObjectsIntegrationTest.kt
@@ -540,7 +540,7 @@ class ObjectsIntegrationTest : BaseIntegrationTest() {
         pubnub.manageChannelMembers(
             channel = channel,
             usersToSet = listOf(PNMember.Partial(uuidId = testUserId01, status = status01, type = type01)),
-            usersIdsToRemove = listOf(),
+            userIdsToRemove = listOf(),
             include = MemberInclude(includeStatus = true, includeType = true)
         ).sync()
 
@@ -582,7 +582,7 @@ class ObjectsIntegrationTest : BaseIntegrationTest() {
             pubnub.manageChannelMembers(
                 channel = channel,
                 usersToSet = listOf(),
-                usersIdsToRemove = listOf(testUserId01, testUserId02),
+                userIdsToRemove = listOf(testUserId01, testUserId02),
             ).sync().data
 
         assertThat(removeResult, not(containsInAnyOrder(testUuidMatcher, otherTestUuidMatcher)))
@@ -598,7 +598,7 @@ class ObjectsIntegrationTest : BaseIntegrationTest() {
         pubnub.manageChannelMembers(
             channel = channel,
             usersToSet = listOf(PNMember.Partial(uuidId = testUserId01, status = status01)),
-            usersIdsToRemove = listOf(),
+            userIdsToRemove = listOf(),
         ).sync()
 
         val getAllResult =
@@ -632,7 +632,7 @@ class ObjectsIntegrationTest : BaseIntegrationTest() {
             pubnub.manageChannelMembers(
                 channel = channel,
                 usersToSet = listOf(),
-                usersIdsToRemove = listOf(testUserId01, testUserId02),
+                userIdsToRemove = listOf(testUserId01, testUserId02),
             ).sync().data
 
         assertThat(removeResult, not(containsInAnyOrder(testUuidMatcher, otherTestUuidMatcher)))