Skip to content

Commit

Permalink
Fix mutated request usage (#86)
Browse files Browse the repository at this point in the history
fix(request): fix request mutators apply

Fix issue because of which request with applied mutators not used.

refactor(codeowners): update list of codeowners

Update list of codeowners and files for which they responsible.

build: integrate with release notifications

Add support for release process notifications.
  • Loading branch information
parfeon authored Nov 5, 2021
1 parent bcb41ad commit f05433e
Show file tree
Hide file tree
Showing 8 changed files with 16 additions and 10 deletions.
4 changes: 2 additions & 2 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
* @parfeon @CraigLn
README.md @crimsonred @techwritermat
.pubnub.yml @crimsonred @techwritermat
.github/* @parfeon @CraigLn
README.md @techwritermat @kazydek
1 change: 1 addition & 0 deletions .github/workflows/commands-handler.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,4 @@ jobs:
with:
token: ${{ secrets.GH_TOKEN }}
listener: client-engineering-bot
jira-api-key: ${{ secrets.JIRA_API_KEY }}
2 changes: 1 addition & 1 deletion .github/workflows/releasae.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,5 +53,5 @@ jobs:
uses: ./.github/.release/actions/actions/services/github-release
with:
token: ${{ secrets.GH_TOKEN }}
jira-api-key: ${{ secrets.JIRA_API_KEY }}
last-service: true

9 changes: 7 additions & 2 deletions .pubnub.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,14 @@
---
name: swift
scm: github.com/pubnub/swift
version: "4.1.0"
version: "4.1.1"
schema: 1
changelog:
- date: 2021-11-05
version: 4.1.1
changes:
- type: bug
text: "Fix issue because of which request with applied mutators not used."
- date: 2021-09-16
version: 4.1.0
changes:
Expand Down Expand Up @@ -419,7 +424,7 @@ sdks:
- distribution-type: source
distribution-repository: GitHub release
package-name: PubNub
location: https://github.com/pubnub/swift/archive/refs/tags/4.1.0.zip
location: https://github.com/pubnub/swift/archive/refs/tags/4.1.1.zip
supported-platforms:
supported-operating-systems:
macOS:
Expand Down
4 changes: 2 additions & 2 deletions PubNub.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -2514,7 +2514,7 @@
"$(inherited)",
"$(TOOLCHAIN_DIR)/usr/lib/swift/macosx",
);
MARKETING_VERSION = 4.1.0;
MARKETING_VERSION = 4.1.1;
OTHER_CFLAGS = "$(inherited)";
OTHER_LDFLAGS = "$(inherited)";
OTHER_SWIFT_FLAGS = "$(inherited)";
Expand Down Expand Up @@ -2547,7 +2547,7 @@
"$(inherited)",
"$(TOOLCHAIN_DIR)/usr/lib/swift/macosx",
);
MARKETING_VERSION = 4.1.0;
MARKETING_VERSION = 4.1.1;
OTHER_CFLAGS = "$(inherited)";
OTHER_LDFLAGS = "$(inherited)";
OTHER_SWIFT_FLAGS = "$(inherited)";
Expand Down
2 changes: 1 addition & 1 deletion PubNubSwift.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = 'PubNubSwift'
s.version = '4.1.0'
s.version = '4.1.1'
s.homepage = 'https://github.com/pubnub/swift'
s.documentation_url = 'https://www.pubnub.com/docs/swift-native/pubnub-swift-sdk'
s.authors = { 'PubNub, Inc.' => '[email protected]' }
Expand Down
2 changes: 1 addition & 1 deletion Sources/PubNub/Helpers/Constants.swift
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public struct Constant {
}()

static let pubnubSwiftSDKVersion: String = {
"4.1.0"
"4.1.1"
}()

static let appBundleId: String = {
Expand Down
2 changes: 1 addition & 1 deletion Sources/PubNub/Networking/HTTPSession.swift
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ final class HTTPSession {
switch result {
case let .success(mutatedRequest):
request.didMutate(urlRequest, to: mutatedRequest)
self?.didCreateURLRequest(urlRequest, for: request)
self?.didCreateURLRequest(mutatedRequest, for: request)
case let .failure(error):
request.didFailToMutate(urlRequest, with: error)
}
Expand Down

0 comments on commit f05433e

Please sign in to comment.