Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a new Listeners API #153
Adding a new Listeners API #153
Changes from 6 commits
d0ec8a3
2a618a7
72f55ad
f6298bf
bdbcaf5
413683e
8b9ae38
0b9dfef
0c8c389
36dcec4
50654d9
4fcd086
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the "original"
NSPredicate
basically matched the same what is done on the line#192
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it should. It compares two String up to the last occurrence of
.
, assuming both contain the.
character. Let's suppose these scenarios:channel.item.x
and the underlying entity's subscription ischannel.item.*
:channel.item
withchannel.item
✅a.b.c
and the underlying entity's subscription ischannel.item.*
a.b
withchannel.item
🔴There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I finally got it.
I was totally fine with
extension
forString
- it looked better.I probably would use
payload.subscription ?? payload.channel
to match bothchannel
andchannelGroup
subscription type. If a subscription has been created for wildcard subscription, then thesubscription
field will hold the same name (if an event for one of the channels from it) and will be no need for pattern match (just plain==
). The only thing which may require some attention is presence channels / channel group names.