Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wrappers to output Json Strings from server responses #32

Merged
merged 9 commits into from
Oct 31, 2024
Merged

Add wrappers to output Json Strings from server responses #32

merged 9 commits into from
Oct 31, 2024

Conversation

KGronek-Pubnub
Copy link
Contributor

Add:

  • Add wrappers to most functions that return Json with data from servers.

Fix:

  • Fix format of Message Action Timetoken returned from AddMessageTimetoken delegate

@KGronek-Pubnub KGronek-Pubnub self-assigned this Oct 31, 2024
Xavrax
Xavrax approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@Xavrax Xavrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Source/PubnubLibrary/Public/FunctionLibraries/PubnubJsonUtilities.h Outdated Show resolved Hide resolved
Source/PubnubLibrary/Public/PubnubStructLibrary.h Show resolved Hide resolved
Source/PubnubLibrary/Private/PubnubSubsystem.cpp Show resolved Hide resolved
@KGronek-Pubnub KGronek-Pubnub merged commit 61264f6 into master Oct 31, 2024
2 checks passed
@KGronek-Pubnub KGronek-Pubnub deleted the feature/Wrapper branch October 31, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xavrax Xavrax Xavrax approved these changes

Assignees

@KGronek-Pubnub KGronek-Pubnub

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KGronek-Pubnub @Xavrax