Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CustomMessageType support. #37

Merged
merged 8 commits into from
Nov 27, 2024
Merged

Add CustomMessageType support. #37

merged 8 commits into from
Nov 27, 2024

Conversation

KGronek-Pubnub
Copy link
Contributor

Add:

  • CustomMessageType to Publish, Signal, History and all other required places

Modify:

  • Change subscribe to subscribe_v2 - return the whole message_v2 object OnMessageReceived instead of Channel and Message strings

@KGronek-Pubnub KGronek-Pubnub self-assigned this Nov 25, 2024
Xavrax
Xavrax approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@Xavrax Xavrax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Source/PubnubLibrary/Private/PubnubSubsystem.cpp Outdated
//If context was released on deinitializing subsystem it should just return
if(!IsInitialized)
{return;}

//Check for subscribe result
pubnub_res SubscribeResult = pubnub_await(ctx_sub);
if (SubscribeResult != PNR_OK)
//pubnub_res SubscribeResult = pubnub_await(ctx_sub);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, good catch.

@KGronek-Pubnub KGronek-Pubnub merged commit ce45c37 into master Nov 27, 2024
2 checks passed
@KGronek-Pubnub KGronek-Pubnub deleted the feature/custom_message_type branch November 27, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xavrax Xavrax Xavrax approved these changes

Assignees

@KGronek-Pubnub KGronek-Pubnub

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KGronek-Pubnub @Xavrax