Use strict in_array

pug-php · Aug 29, 2023 · 70fd86f · 70fd86f
1 parent 5b09677
commit 70fd86f
Show file tree

Hide file tree

Showing 14 changed files with 22 additions and 19 deletions.
diff --git a/src/JsPhpize/Compiler/Compiler.php b/src/JsPhpize/Compiler/Compiler.php
@@ -256,7 +256,7 @@ protected function visitFunctionCall(FunctionCall $functionCall, $indent)
 
             $functions = str_replace(["\n", "\t", "\r", ' '], '', static::STATIC_CALL_FUNCTIONS);
 
-            if ($applicant === 'new' || in_array($name, explode(',', $functions))) {
+            if ($applicant === 'new' || in_array($name, explode(',', $functions), true)) {
                 return $staticCall;
             }
 
@@ -368,7 +368,7 @@ protected function wrapVariableChildren($children, $indent, $php, $options)
     protected function visitVariable(Variable $variable, $indent, $options = 0)
     {
         $name = $variable->name;
-        if (in_array($name, ['Math', 'RegExp'])) {
+        if (in_array($name, ['Math', 'RegExp'], true)) {
             $this->requireHelper(lcfirst($name) . 'Class');
         }
         if ($variable->scope) {

diff --git a/src/JsPhpize/Compiler/DyiadeTrait.php b/src/JsPhpize/Compiler/DyiadeTrait.php
@@ -23,7 +23,7 @@ protected function compileLazyDyiade($helper, $leftHand, $rightHand)
                     '$_SESSION',
                     '$_REQUEST',
                     '$_ENV',
-                ]);
+                ], true);
         }));
         $variables = array_map('strval', $variables);
         $use = count($variables) ? ' use (&' . implode(', &', array_unique($variables)) . ')' : '';

diff --git a/src/JsPhpize/Compiler/Helpers/MathClass.h b/src/JsPhpize/Compiler/Helpers/MathClass.h
@@ -44,7 +44,7 @@ isset($Math) ? $Math : ($Math = [
         return unpack('f', pack('f', $value))[1];
     },
     'fscale' => function ($value, $inLow, $inHigh, $outLow, $outHigh) {
-        if (in_array(NAN, [$value, $inLow, $inHigh, $outLow, $outHigh])) {
+        if (in_array(NAN, [$value, $inLow, $inHigh, $outLow, $outHigh], true)) {
             return NAN;
         }
         return unpack('f', pack('f', (
@@ -108,7 +108,7 @@ isset($Math) ? $Math : ($Math = [
     },
     'round' => 'round',
     'scale' => function ($value, $inLow, $inHigh, $outLow, $outHigh) {
-        if (in_array(NAN, [$value, $inLow, $inHigh, $outLow, $outHigh])) {
+        if (in_array(NAN, [$value, $inLow, $inHigh, $outLow, $outHigh], true)) {
             return NAN;
         }
         if ($value === INF || $value === -INF) {

diff --git a/src/JsPhpize/Lexer/DataBag.php b/src/JsPhpize/Lexer/DataBag.php
@@ -18,17 +18,17 @@ public function __construct($type, array $data)
 
     public function is($value)
     {
-        return in_array($value, [$this->type, $this->value]);
+        return in_array($value, [$this->type, $this->value], true);
     }
 
     public function typeIn($values)
     {
-        return in_array($this->type, $values);
+        return in_array($this->type, $values, true);
     }
 
     public function valueIn($values)
     {
-        return in_array($this->value, $values);
+        return in_array($this->value, $values, true);
     }
 
     public function __get($key)

diff --git a/src/JsPhpize/Lexer/Lexer.php b/src/JsPhpize/Lexer/Lexer.php
@@ -162,7 +162,7 @@ public function next()
             $this->tokenGenerator = $pattern->lexWith($this);
 
             if ($token = $this->pullFromCurrentTokenGenerator()) {
-                if (in_array($pattern->type, $this->disallow)) {
+                if (in_array($pattern->type, $this->disallow, true)) {
                     throw new Exception($pattern->type . ' is disallowed.', 3);
                 }
 

diff --git a/src/JsPhpize/Lexer/Token.php b/src/JsPhpize/Lexer/Token.php
@@ -68,7 +68,7 @@ public function isNeutral()
 
     public function expectNoLeftMember()
     {
-        return in_array($this->type, ['!', '~']) || $this->isVarOperator();
+        return in_array($this->type, ['!', '~'], true) || $this->isVarOperator();
     }
 
     public function isFunction()

diff --git a/src/JsPhpize/Nodes/Block.php b/src/JsPhpize/Nodes/Block.php
@@ -70,7 +70,7 @@ public function getLetVariables()
 
     public function isLet($variable)
     {
-        return in_array($variable, $this->letVariables);
+        return in_array($variable, $this->letVariables, true);
     }
 
     public function handleInstructions()
@@ -84,7 +84,7 @@ public function handleInstructions()
             'interface',
             'class',
             'switch',
-        ]);
+        ], true);
     }
 
     public function needParenthesis()
@@ -96,7 +96,7 @@ public function needParenthesis()
             'for',
             'while',
             'function',
-        ]);
+        ], true);
     }
 
     public function addInstructions($instructions)

diff --git a/src/JsPhpize/Nodes/Constant.php b/src/JsPhpize/Nodes/Constant.php
@@ -39,7 +39,7 @@ class Constant extends Value implements Assignable
      */
     public function __construct($type, $value, $dotChild = false)
     {
-        if (!in_array($type, ['constant', 'number', 'string', 'regexp'])) {
+        if (!in_array($type, ['constant', 'number', 'string', 'regexp'], true)) {
             throw new Exception("The given type [$type] is not a valid constant type.", 23);
         }
 
@@ -54,7 +54,7 @@ public function getNonAssignableReason()
             return "{$this->type} is not assignable.";
         }
 
-        if (in_array($this->value, ['NAN', 'INF'])) {
+        if (in_array($this->value, ['NAN', 'INF'], true)) {
             return "{$this->value} is not assignable.";
         }
 

diff --git a/src/JsPhpize/Parser/Parser.php b/src/JsPhpize/Parser/Parser.php
@@ -89,14 +89,14 @@ protected function parseParentheses($allowedSeparators = [',', ';'])
             }
 
             if ($expectComma) {
-                if ($token->is('in') && in_array('in', $allowedSeparators)) {
+                if ($token->is('in') && in_array('in', $allowedSeparators, true)) {
                     $parentheses->setSeparator('in');
                     $expectComma = false;
 
                     continue;
                 }
 
-                if ($token->isIn(',', ';') && in_array($token->type, $allowedSeparators)) {
+                if ($token->isIn(',', ';') && in_array($token->type, $allowedSeparators, true)) {
                     $expectComma = false;
 
                     continue;

diff --git a/src/JsPhpize/Parser/TokenExtractor.php b/src/JsPhpize/Parser/TokenExtractor.php
@@ -177,7 +177,7 @@ protected function appendFunctionsCalls(&$value, $previousToken = null, $applica
                     $nextValue = new Constant('constant', $nextValue->name);
                 }
 
-                $value = $nextValue instanceof Constant && in_array($nextValue->value, ['Array', 'Object', 'String'])
+                $value = $nextValue instanceof Constant && in_array($nextValue->value, ['Array', 'Object', 'String'], true)
                     ? new FunctionCall(new Variable('is_' . strtolower($nextValue->value), []), [$value], [])
                     : new Dyiade('instanceof', $value, $nextValue);
 

diff --git a/tests/array.php b/tests/array.php
@@ -25,6 +25,7 @@ public function caseProvider()
 
     /**
      * @group array
+     *
      * @dataProvider caseProvider
      */
     public function testArrayResult($expected, $code)

diff --git a/tests/compile.php b/tests/compile.php
@@ -21,6 +21,7 @@ public function caseProvider()
 
     /**
      * @group examples
+     *
      * @dataProvider caseProvider
      */
     public function testJsPhpizeGeneration($phpFile, $jsFile)

diff --git a/tests/options.php b/tests/options.php
@@ -150,7 +150,7 @@ public function testPatternsException()
             'tokenClass' => 'TestToken',
         ]);
         $jsPhpize->removePatterns(function (Pattern $pattern) {
-            return !in_array($pattern->type, ['number', 'operator']);
+            return !in_array($pattern->type, ['number', 'operator'], true);
         });
         $jsPhpize->compile('1 + 1');
     }

diff --git a/tests/render.php b/tests/render.php
@@ -22,6 +22,7 @@ public function caseProvider()
 
     /**
      * @group examples
+     *
      * @dataProvider caseProvider
      */
     public function testJsPhpizeGeneration($returnFile, $jsFile)