-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed minimum-stability: beta suggestion #3
base: master
Are you sure you want to change the base?
Conversation
Thanks for the suggestion @bdunogier! The problem here is that several other required are in beta as well and can't be loaded without requiring them in beta explicitly or setting the minimum-stability. Did the above work for you? |
Hi ! As discussed during the summer camp, I understand the limitation. I'd maybe mention that setting What do you think ? |
Hm I understand your point. We can choose between:
At the moment, I tend to choosing 1 since people testing Puli seems more important to me right now than ensuring that it works safely in production environment. After all, the beta isn't supposed to be used in production. What do you think? |
Well... ;-) |
@@ -42,8 +42,9 @@ following command in a terminal: | |||
|
|||
.. note:: | |||
|
|||
Make sure that the "minimum-stability" setting is set to "beta" in | |||
composer.json, otherwise the installation will fail: | |||
Since puli is in beta phase, it requires that you allow it to install other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uppercase Puli, also in the next paragraph
Looks good! :) The block about "minimum-stability" exists multiple times in the project, could you replace this everywhere? You could also extract the block to a partial template and include it everywhere. |
We are using |
@skolodyazhnyy That's a very good input! @bdunogier Could you adapt the PR? |
Suggesting
minimum-stability: beta
sounds like a bad practice, as it will affect all of the other packages.1.0@beta
should be safer, and do the same thing.