Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed minimum-stability: beta suggestion #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bdunogier
Copy link

Suggesting minimum-stability: beta sounds like a bad practice, as it will affect all of the other packages. 1.0@beta should be safer, and do the same thing.

@webmozart
Copy link
Member

Thanks for the suggestion @bdunogier! The problem here is that several other required are in beta as well and can't be loaded without requiring them in beta explicitly or setting the minimum-stability. Did the above work for you?

@bdunogier
Copy link
Author

Hi !

As discussed during the summer camp, I understand the limitation. I'd maybe mention that setting minimum-stability is one approach, but that it may have serious consequences. And maybe detail the alternative.

What do you think ?

@webmozart
Copy link
Member

Hm I understand your point. We can choose between:

  1. Documenting the easiest way of installation ("minimum-stability": "beta") so that people can easily test Puli
  2. Documenting the safest way of installation (explicit packages with "@beta" suffix) so that Puli can safely be used in production projects

At the moment, I tend to choosing 1 since people testing Puli seems more important to me right now than ensuring that it works safely in production environment. After all, the beta isn't supposed to be used in production. What do you think?

@bdunogier
Copy link
Author

the beta isn't supposed to be used in production

Well... ;-)
But you're right. I have pushed a different version, what do you think ?

@@ -42,8 +42,9 @@ following command in a terminal:

.. note::

Make sure that the "minimum-stability" setting is set to "beta" in
composer.json, otherwise the installation will fail:
Since puli is in beta phase, it requires that you allow it to install other
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uppercase Puli, also in the next paragraph

@webmozart
Copy link
Member

Looks good! :) The block about "minimum-stability" exists multiple times in the project, could you replace this everywhere? You could also extract the block to a partial template and include it everywhere.

@skolodyazhnyy
Copy link

We are using minimum-stability: beta together with prefer-stable: true. It works great.

@webmozart
Copy link
Member

@skolodyazhnyy That's a very good input!

@bdunogier Could you adapt the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants